CFE-90: Excluded the rootless container store from chown of jenkins home - #2421
Open
nickanderson wants to merge 2 commits into
Open
CFE-90: Excluded the rootless container store from chown of jenkins home#2421nickanderson wants to merge 2 commits into
nickanderson wants to merge 2 commits into
Conversation
chown(2) clears setuid bits even when the owner is unchanged, so the pre-build chown -R stripped /usr/bin/sudo inside stored image layers and broke every container build that reused an image. Ticket: CFE-90 Changelog: none
This reverts commit e19e324. The range was already correct on the CI hosts; setuid bits were lost to chown, not to the id mapping. Ticket: CFE-90 Changelog: none
craigcomstock
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre-build
chown -R jenkins /home/jenkinswalks the rootless container store, andchown(2)clears setuid bits even when the owner is unchanged, so/usr/bin/sudoinside stored image layers lost its setuid bit and every container build that reused an image failed. Container hosts now skip the store and only chown what is not already owned by jenkins.Also reverts e19e324, which addressed the same failure on the wrong premise: the subuid range was already correct on the CI hosts.